Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] php8 assign formTpl in HookTest test #22061

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

demeritcowboy
Copy link
Contributor

Overview

On my local the pagerun test passes fine and the buildform one fails but with a different smarty var, so I'm not sure what's different. Possibly it matters if you run the whole suite vs just the file but then that implies there's another problem somewhere - 🤷

Let's see what happens here.

@civibot
Copy link

civibot bot commented Nov 12, 2021

(Standard links)

@seamuslee001
Copy link
Contributor

test fail unrelated

@seamuslee001 seamuslee001 merged commit d77cdd4 into civicrm:master Nov 12, 2021
@demeritcowboy demeritcowboy deleted the formtpl2 branch November 12, 2021 21:14
@demeritcowboy
Copy link
Contributor Author

Yay down to one!

I can't get that last test to fail on my local, but I'll push up a theoretical fix.

@seamuslee001
Copy link
Contributor

@demeritcowboy beat ya to it on the theoretical fix #22065

@demeritcowboy
Copy link
Contributor Author

Hehe cool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants