-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
authx - Add configuration screen #22058
Conversation
(Standard links)
|
test this please |
jenkins, test this please |
@kainuk Oooh, I really like that you added a configuration screen! I notice this branch didn't bring over the description or the test-coverage from #19727. It makes sense -- the tests were still failing due to the (1) I've ported your fix for (2) I tried out the new config screen, and it was working. 👍 Kind of impressed that it worked with so little code. I haven't lookd at |
test this please |
test this please |
Rebased to resolve recent conflicts. To address my own review-feedback, I added a few commits to tweak the settings. It still uses the generic Updated description to add a screenshot of the final page. Merge on pass. |
733275e
to
eafc90f
Compare
jenkins, test this please Process note: Something quirky happened with Github. Contemporaneous with the previous comment, I force-pushed a very small copyedit (adding like 2-5 words; end commit eafc90f), but it didn't appear in web UI for 15+ min, and it didn't send a webhook. |
Process note: Hrm, Github also hasn't sent the webhook for Well, there's a test-run for a nearly identical commit https://test.civicrm.org/job/CiviCRM-Core-PR/46962/ which we can use instead... |
It took a while but the test run eventually started |
Overview
This extends the functionality of #19727 and adds a configuration screen. This will help with configuring for use with https://github.com/CiviMRF.
After