[NFC] dev/mail#103 Add in unit test to demonstate issue with API…

[seamuslee001]

Overview

This test is currently failing but does replicate the issue
See https://lab.civicrm.org/dev/mail/-/issues/103

Before

No Test

After

Test

ping @colemanw @eileenmcnaughton

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

I see, so the problem is that the custom group name contains an illegal character (a space).
Perhaps the fix needs to be an upgrade query such as

UPDATE civicrm_custom_group SET name = REPLACE(name, ' ', '_');

[colemanw]

And/or maybe this: #22049

[colemanw]

Before merging this PR I would add a comment to the test that spaces in machine names are not allowed!
If those backticks solve the problem, great, but it's still not something we want to encourage.
Also, note that you had to resort to using sql directly to get spaces in the name, because the api won't let you do it!

[seamuslee001]

@colemanw I have added a comment to the test now and I think this is mergeable now

[colemanw]

retest this please

[colemanw]

Actually @seamuslee001 there is a BaseCustomValueTest class in the APIv4 tests to help with custom field cleanup so we probably want this test to extend that class.

[seamuslee001]

ok done @colemanw