Escape-on-output: Cleanup addCampaignToSearch, remove isset

[eileenmcnaughton]

Overview

Cleanup addCampaignToSearch

Before

The functionality to add a campaign filter to a search and to add a campaign field to a component form are in the same tpl but the code run is mutually exclusive. Lots of complexity used to maintain this

After

Separate tpls, less variable assignments needed as a result and we can ditch the isset that upsets escape-on-output

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@seamuslee001 @colemanw @demeritcowboy any chance I can get this pushed through?

[demeritcowboy]

I can take a look.
Jenkins retest this please.

[eileenmcnaughton]

thanks @demeritcowboy

[eileenmcnaughton]

thanks @seamuslee001 @demeritcowboy