CiviCRM Membership Status can never be deleted when logging is enabled

[agileware-justin]

CiviCRM Membership Status can never be deleted when logging is enabled, if the membership status was used once. Because there is a check in the membership log table for records having this membership status.

Membership Status delete function appears to have been copied from Membership Type.

Note, Membership Type can be deleted with no such check.

Before

Cannot delete Membership Status.

After

Can delete Membership Status.

Technical Details

Fixed incorrect references to Membership Type in code comments.

Comments

Agileware Ref: CIVICRM-1885

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

This makes sense to me - I'll see if I can get a couple more thumbs up to confirm no-one sees a problem

[johntwyman]

I've tested this and can confirm the problem exists and that the PR solves it. Nice work @agileware-justin

[eileenmcnaughton]

Based on the above I've added merge-ready. If no-one comments agains this we will merge in a few days