Flip logic for determining if $section variable is set. #22027
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Previously empty() function calls were added in order to provide PHP8 compatiability,
however, the logic commited was back-to-front.
This broke the ability to display pie and bar charts for those reports which support them.
Before
Attempting to display a bar or pie chart for a report failed, with the following error message in the browser devconsole:
After
Pie and bar charts should work again.
Technical Details
This was broken in 0c1caf1.
TBH I'm not sure what the check on
$section
is doing, or if it's even needed. Maybe someone smarter than me will know? Seemed safest to just leave it be for now though.