CRM_Utils_File::isChildPath - Fix checking of non-existent paths #22021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suppose you use call `isChildPath()` with these options: * `$parent='/nonexistent'` * `$child='/home/me/exists.txt'` * `$checkRealPath=TRUE` Before ===== Reports that `/home/me/exists.txt` is a child of `/nonexistent` After ===== Reports that `/home/me/exists.txt` is NOT a child of `/nonexistent` Comments ======== I added six test cases for how `isChildPath()` behaves when using `$checkRealPath=TRUE`. The first five cases behave the same with or without the patch. The patch fixes the last case.
|
(Standard links)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fixes an edge case for the utility function,
isChildPath(). Suppose you use callisChildPath()with these options:$parent='/nonexistent'$child='/home/me/exists.txt'$checkRealPath=TRUEDo you regard the real file
/home/me/exists.txtas a child of/nonexistent?Before
Reports that
/home/me/exists.txtis a child of/nonexistent.After
Reports that
/home/me/exists.txtis NOT a child of/nonexistent.Comments
I added six test cases for how
isChildPath()behaves when using$checkRealPath=TRUE. The first five cases behave the same with or without the patch. The patch fixes the last case.