Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Fix test issue about trying to do array offset on NULL in Payme… #22020

Merged
merged 1 commit into from
Nov 10, 2021
Merged

[NFC] Fix test issue about trying to do array offset on NULL in Payme… #22020

merged 1 commit into from
Nov 10, 2021

Conversation

seamuslee001
Copy link
Contributor

…nt ProcessorFormTest

Overview

Fixes test failure because _paymentProcessor was NULL

CRM_Core_Payment_ProcessorFormTest::testPaymentProcessorWithStandardBillingRequirements
Trying to access array offset on value of type null

/home/jenkins/bknix-edge/build/build-0/web/sites/all/modules/civicrm/CRM/Core/Payment.php:983

Before

Test fails on php7.4 and later

After

Test passes

ping @eileenmcnaughton @demeritcowboy

@civibot
Copy link

civibot bot commented Nov 10, 2021

(Standard links)

@civibot civibot bot added the master label Nov 10, 2021
@eileenmcnaughton eileenmcnaughton merged commit b7dad67 into civicrm:master Nov 10, 2021
@eileenmcnaughton eileenmcnaughton deleted the nfc_payment_test_fix branch November 10, 2021 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seamuslee001 @eileenmcnaughton