Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Colombia missing state #22007

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

joapta
Copy link
Contributor

@joapta joapta commented Nov 8, 2021

There is a missing state for Colombia added according to: https://www.iso.org/obp/ui/#iso:code:3166:CO

@civicrm-builder
Copy link

Can one of the admins verify this patch?

@civibot
Copy link

civibot bot commented Nov 8, 2021

(Standard links)

@civibot civibot bot added the master label Nov 8, 2021
@seamuslee001
Copy link
Contributor

Jenkins ok to test

@demeritcowboy
Copy link
Contributor

Oops this is conflicted now. Can you rebase?

@seamuslee001
Copy link
Contributor

@joapta are you able to fix the conflicts here?

@demeritcowboy
Copy link
Contributor

Hi @joapta you need to rebase and squash the commits because the first commit is still a conflict. See https://docs.civicrm.org/dev/en/latest/tools/git/#rebasing

Applying: Add Colombia missing state                                                     
  Patch failed at 0001 Add Colombia missing state                                          
  When you have resolved this problem, run "git am --continue".                            
  If you prefer to skip this patch, run "git am --skip" instead.                           
  To restore the original branch and stop patching, run "git am --abort".                  
  [[ STDERR ]]                                                                             
  error: patch failed: CRM/Upgrade/Incremental/sql/5.45.alpha1.mysql.tpl:1                 
  error: CRM/Upgrade/Incremental/sql/5.45.alpha1.mysql.tpl: patch does not apply           
  error: patch failed: sql/civicrm_generated.mysql:11878                                   
  error: sql/civicrm_generated.mysql: patch does not apply                                 
  error: patch failed: xml/templates/civicrm_state_province.tpl:4142                       
  error: xml/templates/civicrm_state_province.tpl: patch does not apply                    
  hint: Use 'git am --show-current-patch' to see the failed patch

@colemanw colemanw force-pushed the feature/add-missing-colombia-state branch from a4edaaf to 48e6820 Compare November 24, 2021 02:57
@colemanw
Copy link
Member

I've rebased it for you

@colemanw colemanw merged commit 286a8f8 into civicrm:master Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants