-
-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidy up title attributes #21995
Tidy up title attributes #21995
Conversation
(Standard links)
|
I agree with all these changes, but would also like to see the capitalization cleaned up. |
1292c13
to
f15ed32
Compare
I've updated the casing for "Select rows". Occurances of "Contribution Count" and "view details" (with poor capitalisation) already exist elsewhere in the codebase, so I've not updated as presumably doing so would require re-translation? |
In the short-term, yes but in general it's a pain for translators to have multiple inconsistent versions of the same string. |
I can update, but just to be clear, at the moment there are no occurances of "View details" (with capital) only "view details" (lowercase) in |
I would say yes, update all occurrences of "view details" so that in the future translators will only need to deal with one version of that string. |
Wrap text in {ts} as appropriate (for translation) Remove poorly worded or superflous title attributes
f15ed32
to
4bb0b61
Compare
Ok, "View details" is now capitalised. |
Looks much better! And thanks for keeping it rebased to a single commit. |
Overview
Tidy up title attributes:
Wrap text in {ts} as appropriate (for translation)
Remove poorly worded or superflous title attributes
Before
Hardcoded title attributes, some of which were very pooly worded.
After
All title attributes can be translated.
Title attributes removed from
templates/CRM/Activity/Selector/Activity.tpl
andtemplates/CRM/Custom/Form/Field.tpl
as they were poorly worded and didn't provide value.Title attributes from
templates/CRM/Event/Page/ManageEvent.tpl
as they didn't provide additional context from the visible text shown, and so to avoid unnecessary translation effort.