SearchKit - Fix incorrect pager count when using filters #21967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where filters were not being applied correctly when fetching rowCount
|
(Standard links)
|
12f2f27 to
afb75a2
Compare
|
I gave this a quick spin & the count seems good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a bug where filters were not being applied correctly when fetching rowCount, and also improves the output from
SearchDisplay::getDefault.Before
Pager incorrect (if > 1 page) after applying a filter.
SearchDisplay::getDefaultdoesn't fully support pseudoconstants.After
Fixed, with tests.