Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining usages of contact & domain values in participant templates #21963

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Nov 3, 2021

Overview

This removes the last instances of the (uncommon) pattern when $domain and $contact are used in the templates rather than the tokens

Before

Participant templates use $domain & $contact

After

Relevant tokens used - hookTokens is now obsolete - although removing this call to it will be in a follow up

Technical Details

@demeritcowboy @seamuslee001 these are the last 2 templates with this pattern. I feel like we've worked through it carefully enough that this simple PR makes sense next. However, if this is merged I will do (yet another) regen + some clean up around variables etc & maybe look at some of those participant & event tokens.

Comments

@civibot
Copy link

civibot bot commented Nov 3, 2021

(Standard links)

@civibot civibot bot added the master label Nov 3, 2021
@eileenmcnaughton eileenmcnaughton changed the title Remove remaining usages of contact & domain values in participant tem… Remove remaining usages of contact & domain values in participant templates Nov 3, 2021
@seamuslee001
Copy link
Contributor

Jenkins re test this please

@seamuslee001
Copy link
Contributor

Looks fine to me MOP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants