Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Fix pseduoconstant token rendering for contributions via legacy… #21958

Conversation

seamuslee001
Copy link
Contributor

… way on php8 and include campaign_id pseudoconsntants as well

Overview

In php8 something seems to affect the way the array merge is done not sure how but it does which meant that the psuedo fields for contribution tokens weren't ending up in the static tokens['contribution'] array in this class in php8 causing the test failures https://test.civicrm.org/job/CiviCRM-Core-Edge/CIVIVER=5.43,label=test-3/lastCompletedBuild/testReport/(root)/CRM_Contribute_ActionMapping_ByTypeTest/testTokenRendering/ https://test.civicrm.org/job/CiviCRM-Core-Edge/CIVIVER=5.43,label=test-3/lastCompletedBuild/testReport/junit/(root)/CRM_Contribute_BAO_ContributionTest/testReplaceContributionTokens/

Before

Tests fail on php8

After

Tests pass on php8

ping @eileenmcnaughton @demeritcowboy

… way on php8 and include campaign_id pseudoconsntants as well
@civibot
Copy link

civibot bot commented Nov 2, 2021

(Standard links)

@eileenmcnaughton
Copy link
Contributor

if tests pass I'm happy

@seamuslee001
Copy link
Contributor Author

test fails unrelated

@seamuslee001 seamuslee001 merged commit 9d10b6c into civicrm:5.43 Nov 2, 2021
@seamuslee001 seamuslee001 deleted the fix_token_rendering_campaign_legacy_php8 branch November 2, 2021 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants