[REF] Fix pseduoconstant token rendering for contributions via legacy… #21958
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… way on php8 and include campaign_id pseudoconsntants as well
Overview
In php8 something seems to affect the way the array merge is done not sure how but it does which meant that the psuedo fields for contribution tokens weren't ending up in the static tokens['contribution'] array in this class in php8 causing the test failures https://test.civicrm.org/job/CiviCRM-Core-Edge/CIVIVER=5.43,label=test-3/lastCompletedBuild/testReport/(root)/CRM_Contribute_ActionMapping_ByTypeTest/testTokenRendering/ https://test.civicrm.org/job/CiviCRM-Core-Edge/CIVIVER=5.43,label=test-3/lastCompletedBuild/testReport/junit/(root)/CRM_Contribute_BAO_ContributionTest/testReplaceContributionTokens/
Before
Tests fail on php8
After
Tests pass on php8
ping @eileenmcnaughton @demeritcowboy