Use null variables rather than isset in Core_Block #21957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes an isset from LangSwitch and some enotices that we see if escape on output is enabled. 'langSwitch' is normally always assigned by the smarty initialize but for some reason not via this path
|
(Standard links)
|
|
Jenkins re test this please |
seamuslee001
reviewed
Nov 4, 2021
| public function ensureVariablesAreAssigned(array $variables): void { | ||
| foreach ($variables as $variable) { | ||
| if (!isset($this->get_template_vars()[$variable])) { | ||
| $this->assign($variable); |
There was a problem hiding this comment.
what is the actually value here that is getting assigned?
|
This seems fine to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Use null variables rather than isset in Core_Block
Before
Variables may not be assigned - requiring checking with 'empty' or 'isset'
After
Variables always assigned - they might stay NULL or be overwritten later
Technical Details
This removes an isset from LangSwitch and some enotices that we see if escape on output is enabled.
'langSwitch' is normally always assigned by the smarty initialize but for some reason not via this path
Comments