Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GroupContactCache: Drop temp table *after* releasing lock #21942

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

mattwire
Copy link
Contributor

Overview

Currently we drop the temporary table before updating the cache time and before releasing the locks. This cleanup is not critical and should be outside the locked section for performance.

Before

Temporary table dropped within lock before updating cache time.

After

Temporary table dropped after lock is released.

Technical Details

Comments

@civibot
Copy link

civibot bot commented Oct 30, 2021

(Standard links)

@civibot civibot bot added the master label Oct 30, 2021
@mattwire mattwire changed the title GroupContactCache: Drop temp table after releasing lock GroupContactCache: Drop temp table *after* releasing lock Oct 30, 2021
@seamuslee001
Copy link
Contributor

this seems fine to me @eileenmcnaughton ?

@eileenmcnaughton
Copy link
Contributor

Yeah - it makes sense

@eileenmcnaughton eileenmcnaughton merged commit 49dca11 into civicrm:master Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants