Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enotice fixes in debug.tpl that are compatible with default escaping #21940

Merged
merged 1 commit into from
Nov 7, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Enotice fixes in debug.tpl that are compatible with default escaping

Before

Enotices because the way smarty.get works doesn't suppress enotices when used with empty

After

Uses isset - also uses |smarty:notdefaults so it will not break if we turn on default escaping with smarty - see #21935

Technical Details

Comments

@civibot
Copy link

civibot bot commented Oct 29, 2021

(Standard links)

@civibot civibot bot added the master label Oct 29, 2021
@demeritcowboy
Copy link
Contributor

I notice that smarty's own debug.tpl now gives an error if you try to use {debug}. I wonder if there's a way to exclude it in your function.

@demeritcowboy
Copy link
Contributor

I mean with the setting turned on, smarty's own debug.tpl calls isset which then crashes.

@demeritcowboy demeritcowboy merged commit 2ec7e01 into civicrm:master Nov 7, 2021
@eileenmcnaughton eileenmcnaughton deleted the debug branch November 7, 2021 22:09
@eileenmcnaughton
Copy link
Contributor Author

oh yeah - maybe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants