Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cleanup on test, also NFC cleanup #21910

Merged
merged 1 commit into from
Oct 23, 2021
Merged

Fix cleanup on test, also NFC cleanup #21910

merged 1 commit into from
Oct 23, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Oct 23, 2021 •
edited
Loading

Overview

Fix cleanup on test, also NFC cleanup

image

Before

Tests in post-validate for this class have started failing due to the test not doing a good job of cleaning up after itself

After

Using the more thorough cleanup function in tearDown

Technical Details

The failing test was just expanded & there must have been a merge order issue for why it forgave this test class until it didn't

Comments

@civibot
Copy link

civibot bot commented Oct 23, 2021

(Standard links)

@civibot civibot bot added the master label Oct 23, 2021
@demeritcowboy
Copy link
Contributor

Style issue.

Yeah my guess is a merge order issue between #21848 and #21892

@eileenmcnaughton
Fix cleanup on test, also NFC cleanup
f3460c7 
This test was not cleaning itself up very well in the tearDown - causing the post test validate to fail
@eileenmcnaughton eileenmcnaughton merged commit 2b4f6f2 into civicrm:master Oct 23, 2021
@eileenmcnaughton eileenmcnaughton deleted the new_validate branch October 23, 2021 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @demeritcowboy