Use SVG for 'Empowered by' logo #21841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Looks great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
https://lab.civicrm.org/dev/core/-/issues/2913
Out of the box, CiviCRM contains an "Empowered by CiviCRM" line at the bottom of certain pages, including public-facing screens. Currently this uses civi99.png which has been unchanged for at least 7 years
On some screens, especially high-definition screens, this PNG can look rather blurry. I'd like to suggest that an SVG is used instead.
Before
A png was used, which looked blurry on high-definition screens. (or when zoomed in)
After
An SVG equivalent is used instead (on browsers which support it)
Technical Details
The png logo has been left as a fallback for older browsers which do not support SVG (older Internet Explorer), using the technique found here: https://css-tricks.com/using-svg/#browser-support
Some third-party admin themes (e.g. https://github.com/christianwach/civicrm-admin-utilities/) will need to update their CSS to make use of this improvement.