Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hookTokens to be clearable outside the class #21836

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Fix hookTokens to be clearable outside the class

Before

Tests can't unset the proerty in the class easily

After

hook tokens can be flushed from within unit tests

Technical Details

Comments

Tests can't unset the proerty in the class easily but just using the static makes it easier
@civibot
Copy link

civibot bot commented Oct 14, 2021

(Standard links)

@civibot civibot bot added the master label Oct 14, 2021
@totten
Copy link
Member

totten commented Oct 15, 2021

Lots of test coverage in this area. Looks like a safe refactoring.

@totten totten merged commit 5b6ef63 into civicrm:master Oct 15, 2021
@eileenmcnaughton eileenmcnaughton deleted the hook_toke branch October 15, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants