SearchKit server-side rendering #21820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
16e8f10 to
1ea397d
Compare
1f30fb7 to
ba6ef69
Compare
738d9ac to
97b5409
Compare
Moves logic for resolving field values from the client to the server-side, which gives more control over formatting, links, and greater consistency of spreadsheet output.
97b5409 to
c0fcc64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Improves SearchKit by doing more of the rendering work server-side. This allows for more nuanced permission checks of actions, better rendering of spreadsheets, and opens the door for advanced token formatting.
Before
The
SearchDisplay::run()api was a thin wrapper around*::get(), with not much pre or post-processing. Formatting of results (e.g. token replacements, rewrites, adding links, image handling, and in-place edit processing) happens client-side.After
The
SearchDisplay::run()api does basically all the preprocessing and formatting of results.Technical Details
This PR just does the refactoring needed to switch the column formatting from client to server. Advanced stuff like ACL checks of links hasn't been added yet, as this PR is already big and complex enough. But that can be added in a followup PR.
Comments
While testing this I noticed extremely poor performance when the search display had some editable columns. I fixed that with #21920