dev/core#2864 Remove call to getTokenDetails from Contribute pdf letter

[eileenmcnaughton]

Overview

dev/core#2864 Remove call to getTokenDetails from Contribute pdf letter

Before

A call is being done to render tokens that are not eventually used

After

apiv3 call

Technical Details

On digging this is just a glorifed api call. The parameters loaded are only used in emailLetter for filtering - since the values are not being used I didn't try to squeeze it into the rc

Comments

CRM_Contribute_Form_Task_PDFLetterCommonTest runs through this - there is a full process test that checks the tokens are resolved - but I have edited the test that specifically checks this function adds the token hook

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@seamuslee001 added the test

[seamuslee001]

ok this works for me now merging