Do not find references for empty values #21799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
CRM/Core/Reference/Basic.php
Outdated
| @@ -113,7 +113,7 @@ public function findReferences($targetDao) { | |||
| public function getReferenceCount($targetDao) { | |||
| $targetColumn = $this->getTargetKey(); | |||
| $params = [ | |||
| 1 => [$targetDao->$targetColumn, 'String'], | |||
| 1 => [$targetDao->$targetColumn ?? '', 'String'], | |||
There was a problem hiding this comment.
also I would have thought that needs to be $targetDao->{$targetColumn} but that seems fine for the casting tho
There was a problem hiding this comment.
@seamuslee001 I've updated this to bypass the query if null rather than 'make it work' after more thought/discussion. I did adopt your syntax although I think they are probably equally ok
c33e687 to
283e84b
Compare
283e84b to
eb2a487
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Do not find references for empty strings or null values when looking for references to an entity
Before
The reference count query throws a fatal error if the target column is NULL and returns matches for an empty string
After
A result of 0 is returned when there is no usable value
Technical Details
When looking for references to a column we really want references to 'real values' not empty fields. 0 is a bit ambiguous & behaviour is unchanged.
Comments