Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchKit - Fix in-place edit in 5.42 #21769

Merged
merged 1 commit into from
Oct 9, 2021

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Oct 8, 2021

Overview

This is a partial backport of 3a608fe to fix a regression with in-place edit in SearchKit.

Before

Create a search for contacts with emails. Make the email address editable. It's broken.

After

It works.

Comments

This is already in master & 5.43 so doesn't need forward merging.

@civibot
Copy link

civibot bot commented Oct 8, 2021

(Standard links)

@civibot civibot bot added the 5.42 label Oct 8, 2021
@rgilman
Copy link

rgilman commented Oct 8, 2021

As the one who reported this bug, I can confirm that this fixes the issue with in-place edit.

@colemanw
Copy link
Member Author

colemanw commented Oct 9, 2021

retest this please

@rgilman
Copy link

rgilman commented Oct 9, 2021

retest this please

@colemanw, do you want me to retest? It doesn't look like anything has changed.

@eileenmcnaughton
Copy link
Contributor

@rgilman - not that was an instruction to the automated test bot who originally reported a test failure. I'm happy to merge based on your testing

@eileenmcnaughton eileenmcnaughton merged commit 32fff2f into civicrm:5.42 Oct 9, 2021
@eileenmcnaughton eileenmcnaughton deleted the fixEditable branch October 9, 2021 05:41
@eileenmcnaughton
Copy link
Contributor

oh 5.42 is no longer the rc - we need a pr against master

@colemanw
Copy link
Member Author

colemanw commented Oct 9, 2021

Thanks @eileenmcnaughton. Per the comment above, this is already in master & 5.43, so no need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants