Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove function duplicated in error #21758

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Oct 7, 2021

Overview

Remove function duplicated in error

Before

Function mistakenly copied to Contact_tokens when the classes were separated

After

This function lives on & is called on the token compatibility class but is not duplicated

Technical Details

Comments

@totten hopefully this is fresh enough in your mind for it to be an easy merge - tokenCompatibilitySubscriber class has the real copy

This function lives on & is called on the
@civibot
Copy link

civibot bot commented Oct 7, 2021

(Standard links)

@civibot civibot bot added the master label Oct 7, 2021
@yashodha
Copy link
Contributor

yashodha commented Oct 7, 2021

@eileenmcnaughton I can confirm Civi/Token/TokenCompatSubscriber.php has the method, looks like simple cleanup. I am merging this.

@yashodha yashodha merged commit 9efd4e5 into civicrm:master Oct 7, 2021
@eileenmcnaughton eileenmcnaughton deleted the contactv4 branch October 7, 2021 19:01
@eileenmcnaughton
Copy link
Contributor Author

thanks @yashodha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants