Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Afform - ensure dragging classes are removed when not sorting #21750

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Oct 6, 2021

Overview

Fixes an annoying UI glitch in Afform where the screen can appear "locked" or "frozen" after dragging fields into a fieldset.

Comments

This is hard to reproduce on purpose but very annoying when it happens to you. It's such a simple fix I think we should merge it into the RC. I'm usually able to reproduce it by dragging a field from the palette on the left into a container within a fieldset.

Technical Details

Most of this PR is just adding code comments. Only functional change it to listen to more events.

@civibot
Copy link

civibot bot commented Oct 6, 2021

(Standard links)

@civibot civibot bot added the 5.42 label Oct 6, 2021
@colemanw colemanw force-pushed the afformHoverFix branch 2 times, most recently from 90121d6 to b2b2818 Compare October 6, 2021 17:50
@rbaugh
Copy link

rbaugh commented Oct 6, 2021

Came across this odd behavior as well but thought it was something on my end and just refreshed the page. After knowing it was a re-producible bug, I was able to replicate this as well. After applying this PR, I don't seem to get the issue. Can add field to container and click around and it retains ability to edit field

@eileenmcnaughton
Copy link
Contributor

Thanks @rbaugh - appreciate you taking the time to test this PR - I'm merging based on your testing

@eileenmcnaughton eileenmcnaughton merged commit b3a8f01 into civicrm:5.42 Oct 6, 2021
@eileenmcnaughton eileenmcnaughton deleted the afformHoverFix branch October 6, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants