Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function cleanup following move to non-static function #21693

Merged
merged 1 commit into from
Oct 3, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Oct 1, 2021

Overview

Function cleanup following move to non-static function

Before

$this was cast to $form to reduce cognitive load when reviewing the move

After

Now fixed to $this

Technical Details

Comments

@civibot civibot bot added the master label Oct 1, 2021
@civibot
Copy link

civibot bot commented Oct 1, 2021

(Standard links)

@@ -266,7 +265,7 @@ public function postProcess(): void {
$mimeType = $this->getMimeType($type);
// ^^ Useful side-effect: consistently throws error for unrecognized types.

$fileName = method_exists($form, 'getFileName') ? ($form->getFileName() . '.' . $type) : 'CiviLetter.' . $type;
$fileName = $this->getFileName();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

method is in around line 191 of this file - the check was transitional

@colemanw colemanw merged commit a7e7a22 into civicrm:master Oct 3, 2021
@colemanw colemanw deleted the object branch October 3, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants