Enotice tpl fix #21689
Merged
Enotice tpl fix #21689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
colemanw
reviewed
Oct 2, 2021
| @@ -12,7 +12,7 @@ | |||
| {if !empty($searchtype) && $searchtype eq 'ts_sel'} | |||
| <div id="popupContainer"> | |||
| <div class="crm-block crm-form-block crm-search-form-block"> | |||
| <table id="selectedRecords-{$group.id}" class="display crm-copy-fields crm-sortable"> | |||
| <table id="selectedRecords-{if !empty($group)}{$group.id}{/if}" class="display crm-copy-fields crm-sortable"> | |||
There was a problem hiding this comment.
This is really weird. What is this dom id even used for?
Should we wrap the whole id property of this <table> inside the conditional? An id of "selectedRecords-" seems unlikely to be useful.
There was a problem hiding this comment.
@colemanw I didn't really look - I'm kinda at the point of just trying to make the notices go away & past the stage of thinking about the best way
There was a problem hiding this comment.
Fair enough. A question for another day.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enotice tpl fix