Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return another function to the email trait #21677

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Return another function to the email trait

Before

Function only used from one place in core, code working hard to get the parameters to it

After

Now it is OO on the trait that uses it

Technical Details

Comments

Another function that is only used from one place & is unnecessarily complicated
because of the input & output paramters
@civibot
Copy link

civibot bot commented Sep 30, 2021

(Standard links)

@civibot civibot bot added the master label Sep 30, 2021
@eileenmcnaughton eileenmcnaughton merged commit 8001fe1 into civicrm:master Sep 30, 2021
@eileenmcnaughton eileenmcnaughton deleted the move branch September 30, 2021 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants