Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes core#2874 - Search Builder on State/Province with Primary and IN #21646

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

MegaphoneJon
Copy link
Contributor

@MegaphoneJon MegaphoneJon commented Sep 27, 2021

https://lab.civicrm.org/dev/core/-/issues/2874

Overview

Using Search Builder with a field of "State/Province", a location type of "Primary" and an operator of "IN" causes a validation error. Full replication steps, before/after, etc. are on https://lab.civicrm.org/dev/core/-/issues/2874.

Technical Details

This is a fix to PR #8890, which fixed the case where the Search Builder could be passed a string for a state_province value, but didn't consider the case where it's passed an array.

@civibot
Copy link

civibot bot commented Sep 27, 2021

(Standard links)

@eileenmcnaughton
Copy link
Contributor

yay there's a test

@eileenmcnaughton
Copy link
Contributor

test this please

@eileenmcnaughton eileenmcnaughton merged commit e6e3eea into civicrm:master Oct 7, 2021
@eileenmcnaughton
Copy link
Contributor

Change reads well & the test is compelling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants