Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Afform - ensure default value data type matches input type #21643

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Sep 27, 2021

Overview

Followup to #21606
Fixes mismatch between default value from the URL (which is always a string) and inputs for other types of values - numbers and search ranges.

Before

Url args don't seem to populate for number fields or range inputs.

After

Number fields work as expected. Range fields can be passed through the url with high and low values separated by - like /civicrm/test-form#?my_number_field=123-456

Screenshot is with #21645

image

@civibot
Copy link

civibot bot commented Sep 27, 2021

(Standard links)

@eileenmcnaughton
Copy link
Contributor

test this please

@eileenmcnaughton
Copy link
Contributor

test fails are unrelated & this worked in my testing

@eileenmcnaughton eileenmcnaughton merged commit a3b2493 into civicrm:master Sep 27, 2021
@eileenmcnaughton eileenmcnaughton deleted the afformUrlArgs branch September 27, 2021 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants