dev/core#2629 show only contribution statuses on contribution form #21624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
This arose from digging into https://lab.civicrm.org/dev/core/-/issues/2629 but I think it's a tangent.... However when editing contributions the available statuses are not dependent on the component. Only the contribution status is relevant
61d6379 to
e47077c
Compare
|
Looks good. Works fine on my local setup. Merging now. |
|
thanks @monishdeb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
dev/core#2629 show only contribution statuses on contribution form
Before
Whoa - that code is crazy-confusing
After
Makes a bit more sense
Technical Details
This arose from digging into
https://lab.civicrm.org/dev/core/-/issues/2629
but I think it's a tangent....
The function that looks to find out what contribution statuses to expose passes in the 'component' - but there is no reason the component should be relevant to the contribution status on the contribution edit screen. Note that I think this relates to when we used to overload the contribution_status_id option value for multiple entities
I'm not seeing this as changing anything other than code complexity
@monishdeb can you check this?
Comments