Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find Activities Search, default search option for Activity Text is set to "both" in the code, but should actually be set to 6 which is the value for "both" #21598

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

agileware-justin
Copy link
Contributor

Overview

Find Activities Search, default search option for Activity Text is set to "both" in the code, but should actually be set to 6 which is the value for "both". As a result "both" is not set by default.

Screenshot_20200917_133714

Before

"both" is not set by default.

After

Now "both" is set by default.

Technical Details

Just a bug in the code.

Comments

Agileware Ref: CIVICRM-1846

…ty Text is set to "both" in the code, but should actually be set to 6 which is the value for "both"
@civibot
Copy link

civibot bot commented Sep 24, 2021

(Standard links)

@civibot civibot bot added the master label Sep 24, 2021
@yashodha
Copy link
Contributor

@agileware-justin This looks good to me, tested and works fine. The bug was introduced in 1cd7479#diff-78a97c52d658d73310947a90fecf7f40585837e8ae6afe128064da44b154e3f6R438

I am merging this.

@yashodha yashodha merged commit f22faf0 into civicrm:master Sep 24, 2021
eileenmcnaughton pushed a commit to eileenmcnaughton/civicrm-core that referenced this pull request Sep 24, 2021
Find Activities Search, default search option for Activity Text is set to "both" in the code, but should actually be set to 6 which is the value for "both"
eileenmcnaughton pushed a commit to eileenmcnaughton/civicrm-core that referenced this pull request Sep 24, 2021
Find Activities Search, default search option for Activity Text is set to "both" in the code, but should actually be set to 6 which is the value for "both"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants