Find Activities Search, default search option for Activity Text is set to "both" in the code, but should actually be set to 6 which is the value for "both" #21598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty Text is set to "both" in the code, but should actually be set to 6 which is the value for "both"
|
(Standard links)
|
|
@agileware-justin This looks good to me, tested and works fine. The bug was introduced in 1cd7479#diff-78a97c52d658d73310947a90fecf7f40585837e8ae6afe128064da44b154e3f6R438 I am merging this. |
eileenmcnaughton
pushed a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Sep 24, 2021
Find Activities Search, default search option for Activity Text is set to "both" in the code, but should actually be set to 6 which is the value for "both"
eileenmcnaughton
pushed a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Sep 24, 2021
Find Activities Search, default search option for Activity Text is set to "both" in the code, but should actually be set to 6 which is the value for "both"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Find Activities Search, default search option for Activity Text is set to "both" in the code, but should actually be set to 6 which is the value for "both". As a result "both" is not set by default.
Before
"both" is not set by default.
After
Now "both" is set by default.
Technical Details
Just a bug in the code.
Comments
Agileware Ref: CIVICRM-1846