[REF] Remove illusion of looping

[eileenmcnaughton]

Overview

[REF] Remove illusion of looping

This foreach actually only copes with 1 value. Making that clearer makes it more readable

Before

It loops through the attachments if any but only uses the 'last one'

After

It explicitly only grabs the first one

Technical Details

If the data model only copes with 1 then I don't think first vs last is material - the reality is it works with up to 1 attachment & clarifying that now means we don't have to later....

Most of this handling seems to be because it could be NULL rather than an array

This functionality appears to be about allowing an attachment to be the message template - ie upload a doc as a template rather than save a message template - so more than 1 file makes no sense

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).