Add test and fix for API4 failing to decode strings stored as HTML #21549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
b85b7ee to
2dda69c
Compare
CiviCRM regrettably stores most strings as HTML in the database. This fixes the output of APIv4 write operations to decode them and return non-html
2dda69c to
067dea4
Compare
|
I confirmed the test fails without this fix. Merge-on-pass. |
|
Works for me, thanks for super speedy response, @colemanw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
See
https://chat.civicrm.org/civicrm/pl/yw3u69gi1jnjuek6q8c1s7iq7c
Before
Calling an API DAO create or update with a string returns htmlspecialchars(string) instead of the same string as you wanted to store.
This was not picked up by tests.
After
Same, but this is picked up by tests.
Technical Details
Note that .get actions seem to work OK.