Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "Print Invoice" and "Print Invoice and Credit Note" buttons with label "Download Invoice" and "Download Invoice and Credit Note" #21546

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

agileware-justin
Copy link
Contributor

@agileware-justin agileware-justin commented Sep 20, 2021

Replace "Print Invoice" and "Print Invoice and Credit Note" buttons with label "Download Invoice" and "Download Invoice and Credit Note"

Overview

This button does not send the downloaded PDF to a printer, nor does it open a "printer friendly" page and then show the print dialog. Instead, this button just downloads a PDF and so should be labelled as such.

Before

Clicking Print Invoice button does not print the invoice.

print-invoice

After

Clicking Download Invoice button does download the invoice.

Screenshot_20210920_114448

Technical Details

Replaced FA Print icon with Download icon too.

Comments

Agileware Ref: CIVIBLD-279

…e" buttons with label "Download Invoice" and "Download Invoice and Credit Note"
@civibot
Copy link

civibot bot commented Sep 20, 2021

(Standard links)

@civibot civibot bot added the master label Sep 20, 2021
@colemanw
Copy link
Member

Makes sense to me.

@colemanw colemanw merged commit 9a52649 into civicrm:master Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants