Participant tokens - remove / replace unsupportable from badges (conversion preparation) #21520
Conversation
|
(Standard links)
|
a5289dc to
057e8e6
Compare
There are literally 2 tokens for the same option in the drop down.. remove the non-standard one
These tokens are a) non-standard, not easily supported b) illogical in the only current core usage context that currently uses these tokens (event badges) c) partially broken - currency returns nothing, note doesn't make sense
057e8e6 to
c9ce396
Compare
|
It turns out 2 more tokens will need to go to be supportable. They are in #21530 - I could add them to this but I'm kinda hoping this will be merged & I can simplify that I've added them also to https://lab.civicrm.org/-/ide/project/documentation/docs/sysadmin/tree/case/-/docs/upgrade/version-specific.md/ |
| '{participant.fee_label}' => 'Fee Label', | ||
| '{participant.default_role_id}' => 'Default Role', | ||
| '{participant.template_title}' => 'Event Template Title', | ||
| '{participant.currency}' => 'Currency', | ||
| '{participant.participant_note}' => 'Participant Note', |
There was a problem hiding this comment.
@eileenmcnaughton is there a replacement suggested for these 2?
There was a problem hiding this comment.
@seamuslee001 so per the pr block & docs update - these are only currently available in badges & currency doesn't work so that's easy.
For note - I'm proposing we remove & rely on the docs update (linked above) - since I think it's
a) unlikely to be in use for badges & that is the only usage of this function in core now (fortunately)
b) not on any other token class
c) not a one to one relationship - at the db level anyway
There was a problem hiding this comment.
ok I guess that is enough then
|
This seems fine to me merging |
Overview
Participant tokens - remove / replace unsupportable from badges (conversion preparation)
Before
The drop down for event tokens offers 2 tokens for event title, start date, end date. One is 'standard' - ie
{event.title}the other isn't ie{participant.event_title}Also 2 tokens are offered that are hard to support and don't make sense in this context
{participant.currency}(does not return anything - the field is 'fee_currency' and doesn't make much sense in this context){participant.note}(this does work but I think we can drop support on this one as it is ambiguous if there are multiple notes, it's really hard to support, was exposed by accident and I think it's unlikely it is used).After
Ambiguous tokens consolidated. Support dropped for the 2 problem tokens.
Technical Details
@seamuslee001 If we merge this then next steps are
Comments
I added to the upgrade notes
https://lab.civicrm.org/-/ide/project/documentation/docs/sysadmin/tree/case/-/docs/upgrade/version-specific.md/