dev/core#2816: New contribution can't be saved when validation fails …

[monishdeb]

Overview

Steps to replicate:

1. Define a premium product.
2. Contributions - New Contribution
3. Fill out the contact and the amount, but forget, let's say, the financial type.
4. Click save.
5. Ok it warns you and reloads the form.
6. Now pick Donation.
7. Click save.

Before

After

Technical Details

Regression is caused in 'New Contribution' backoffice form from 5.40 onward, when civicrm_contribution_product.product_id is set as a foreignkey of civicrm_product.id here. As a result the previously code used to insert product_id = 0 for back office contribution and now it ends up in a DB error due to nonexistent product_id = 0. Rest assured this doesn't break CiviCRM upgrade from 5.40 onward because of this DELETE SQL here which also delete entries with non-existent product_ids.

As per the fix is concern, I am not in support of changing the placeholder - select - value to '' from 0, because 0 serves as an indicator on the backoffice contribution edit screen, when one removes the previous product selection.

Comments

ping @eileenmcnaughton @seamuslee001 @colemanw

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

I think this is ok because the UI only supports one premium per contribution.

[demeritcowboy]

Runs ok for me.

[eileenmcnaughton]

Thanks @monishdeb @demeritcowboy