Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Fix Fatal error on php 8 due to mis matched function declaration #21487

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

seamuslee001
Copy link
Contributor

Overview

This fixes the following error on php8

TAP version 13

Fatal error: Declaration of CRM_Contact_Import_Form_MapFieldTest::getFormObject($class, $formValues = [], $pageName = '') must be compatible with CiviUnitTestCase::getFormObject($class, $formValues = [], $pageName = '', $searchFormValues = []) in /home/jenkins/bknix-edge/build/build-0/web/sites/all/modules/civicrm/tests/phpunit/CRM/Contact/Import/Form/MapFieldTest.php on line 135

Before

Tests fail on php8

After

Tests pass on php8

ping @eileenmcnaughton

@civibot
Copy link

civibot bot commented Sep 15, 2021

(Standard links)

@seamuslee001 seamuslee001 merged commit 5be79b3 into civicrm:master Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants