[REF] Extract code to load the contact in tokenCompat #21450
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Extraction of the code to load contact - this is an attempt to break an easy-merge chunk from #21449
Before
getContact
is happening during evaluateAfter
It is extracted
Technical Details
This isn't quite a pure extraction - it adds a bool for
$getAll
which allows us to load all when we want them for the token hook but not to otherwise. The other reason why we were loading all return properties is that last time around we got test fails when we didn't. I'm pretty sure that was because the greeting fields weren't being requested so I've added handling to grab those.Note I also copied the array of return properties to a function since we want to work through them at some point to retrieve using apiv4
Comments