Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchKit - Fix deleting search displays #21444

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

colemanw
Copy link
Member

Overview

Fixes a regression where search displays cannot be deleted from the UI.

Before

  1. Click "Edit" on a saved search with at least one display
  2. Click the trash icon next to a display
  3. Click save
  4. Note the display has not been deleted

After

Fixed

Comments

IDK when this regressed or if it was always broken but it's a simple fix.

@civibot
Copy link

civibot bot commented Sep 12, 2021

(Standard links)

@civibot civibot bot added the 5.42 label Sep 12, 2021
@eileenmcnaughton
Copy link
Contributor

I tested - this works - I find the delete + save a bit confusing - but I think it's by design

image

@eileenmcnaughton eileenmcnaughton merged commit 6d6d62c into civicrm:5.42 Sep 13, 2021
@eileenmcnaughton eileenmcnaughton deleted the fixSearchDisplayDelete branch September 13, 2021 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants