Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchKit - Fix display of links in aggregated columns #21420

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Sep 9, 2021

Overview

Fixes an error caused by trying to make an aggregated column into a link.

Before

  • Create search for Activities
  • Add LEFT join for Activity Contacts
  • Run search, notice that contact display name column is not shown as links
  • Create a display, notice that configuring the contact display name column as links will cause an error

After

Same as above, links work correctly. Also prevents you from adding links when using any aggregate function other than GROUP_CONCAT since it's the only one that can show each aggregated item individually.

Technical Details

This gives special treatment to the GROUP_CONCAT function in SearchKit to match the special treatment it gets in APIv4 (exploding it into an array).

@civibot
Copy link

civibot bot commented Sep 9, 2021

(Standard links)

@eileenmcnaughton
Copy link
Contributor

@kurund were you going to test & hopefully merge this one too?

Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@colemanw @eileenmcnaughton

I have tested and is working as expected. Good to merge.

@colemanw colemanw merged commit a8e3e13 into civicrm:master Sep 15, 2021
@colemanw colemanw deleted the fixSearchKitMultiLink branch September 15, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants