Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[search kit] Semicolon vs comma #21406

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Conversation

demeritcowboy
Copy link
Contributor

Overview

@colemanw This is the error on my local I was seeing earlier. Not sure why it doesn't show on the test site / dmaster.demo.

Before

  • ReferenceError: assignment to undeclared variable apiParams
  • Search kit searches list doesn't load completely

After

Technical Details

Comma

Comments

@civibot
Copy link

civibot bot commented Sep 8, 2021

(Standard links)

@colemanw
Copy link
Member

colemanw commented Sep 8, 2021

Yes that was definitely a typo. MOP.

@demeritcowboy
Copy link
Contributor Author

Oh it's the enable debugging setting. When it's on it seems to also make angular more angrier.

@colemanw
Copy link
Member

colemanw commented Sep 8, 2021

Haha. Too bad the debug setting makes our .tpl based pages nearly unusable, prompting me to turn it off. What idiot added that feature anyway?

@demeritcowboy
Copy link
Contributor Author

He he.
Must have been that other Coleman.

@colemanw colemanw merged commit a77bc9d into civicrm:master Sep 8, 2021
@colemanw
Copy link
Member

colemanw commented Sep 8, 2021

Now I've enabled debug mode and hitting this bug. Merging fixes it.

@demeritcowboy demeritcowboy deleted the comma branch September 8, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants