dev/core#2823 Make protected functions non-static #21395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's really hard to see why this class uses a mix of static & non-static functions for internal (protected) functions. I suspect *history*. This makes them all non-static
|
(Standard links)
|
|
Refactor looks good, looking forward to the next PR in this series. |
|
@colemanw re the next PR - I commented on the ticket but I think my underlying assumption is 'it would be OK to load all rows in the managed table into an array on the class, since I don't think there will be that many' - do you agree? |
|
Yes I agree. PHP can easily handle arrays of a few hundred or even a few thousand items, not that I think there would ever be that many. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
dev/core#2823 Make protected functions non-static
Before
internal protected functions are static
After
And now they're not
Technical Details
It's really hard to see why this class uses a mix of static & non-static functions
for internal (protected) functions. I suspect history. This makes
them all non-static
Comments
Towards https://lab.civicrm.org/dev/core/-/issues/2823