Add workflow template for 'recurring edit' workflow #21356
Conversation
|
(Standard links)
|
c4e8ba3 to
db913c0
Compare
5c3c3aa to
40df2ff
Compare
|
@eileenmcnaughton I've pushed a few more commits up here. Here's what the "Preview" dialog looks like with the new RecurringEdit example:
|
This changes the signature on a new helper method. This method is not widely used, and each reference is updated here. Before: `Civi\Test::example($name)` returns the *metadata* for the example. After: `Civi\Test::example($name)` returns the *data* for the example. Comment: It's more convenient to stitch together examples from the data. Of course, metadata may also be useful -- it's still available through `Civi\Test::examples()->getFoo(...)` (with a few different `getFoo()` methods).
1. Use revised class format
2. Use `entity/{$ENTITY}/{$EXAMPLE}` instead of `workflow/{$WORKFLOW}/{$EXAMPLE}`
|
@eileenmcnaughton I've done revisions and rebasing/squashing to use the |
|
@totten that looks good to me - I'd be happy to merge-on-pass this (with a little PR template editing). I would like to talk about the 'from_email_address' one - because I feel like that could be generic - once this is merged |
…missing properties. This creates a new example of the `RecurringEdit` workflow message. Note that the example is tagged `phpunit` and defines a list of `asserts`. These assertions are evaluated using the default message-template. The test was not passing because some important properties were missing from `RecurringEdit`.
Agree on both points. The Smarty variable |
|
@totten also note that I don't think it's really intentional that the template winds up with the [name + email] format rather than just email - it doesn't read right |
|
@seamuslee001 @colemanw can one of you escalate this to merge-on-pass. I think @totten & I are agreed it should be merged now so just want someone not already a committer on this PR to approve |
|
Lots of tests here :) |
Overview
Add workflow template for 'recurring edit' workflow
Before
now you don't see it
After
now you do
Technical Details
This adds a declared workflow template for the recurring edit workflow
Comments