[REF] dev/core#2790 dev/core#2814 Start migration to MessageTemplate::render

[eileenmcnaughton]

Overview

[REF] dev/core#2790 Start migration to MessageTemplate::render

Before

long chunk of copy & paste used to replace most functions

After

MessageTemplate::render function used

Technical Details

• the test cover should mean we can switch to using the api once the api is available if this is merged first
• I've left the case tokens for later - hence they are before the smarty handling
• we know the contact tokens have been reconciled
• I want to remove this chunk as a follow up -

  civicrm-core/CRM/Contact/Form/Task/PDFLetterCommon.php

  Lines 138 to 150 in 758b39a

  	list($contact) = CRM_Utils_Token::getTokenDetails($params,
  	$returnProperties,
  	$skipOnHold,
  	$skipDeceased,
  	NULL,
  	$messageToken,
  	'CRM_Contact_Form_Task_PDFLetterCommon'
  	);
  	if (civicrm_error($contact)) {
  	$notSent[] = $contactId;
  	continue;
  	}

  - however it is still achieving 2 things for now
  1. possibly maybe filtering out deceased & on hold - I have my doubts but havent tested yet - that should be done before the rendering starts IMHO
  2. retrieving the contact to assign to the template IF smarty is enabled
• @totten - this last point throws up a variant of what we have been discussing - an annoying variant - note I don't see it as blocking on merging this - just something for next PR

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@demeritcowboy I'm gonna clean this rendering up before moving to the trait. I have some thoughts about cleaning up the case part too but this change should be small & safe IMHO

[eileenmcnaughton]

Also - it starts to add the test cover for tokens here

[colemanw]

Refactoring looks good and tests look solid.