[REF] dev/core#2790 Deprecate CRM/Member/Form/Task/PDFLetterCommon #21305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
This gets rid of the pseudo oo model on this class and gets us to only having 2 classes in play We are moving towards a trait
881f0ef to
b0a0d68
Compare
|
@demeritcowboy I think this one should be pretty straight forward |
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[REF] dev/core#2790 Deprecate CRM/Member/Form/Task/PDFLetterCommon
Before
Functionality spread across 3 classes
After
Spread across 2
Technical Details
This gets rid of the pseudo oo model on this class
and gets us to only having 2 classes in play
We are moving towards a trait
Comments