CiviCRM Scheduled Reminders, Effective Start Date and Effective End Date are incorrectly evaluated if these fields contain a value '0000-00-00 00:00:00' #21250
Conversation
|
(Standard links)
|
|
@agileware-justin should we be targetting the rc / porting this to 5.40? I can see the expecation was that it would be NULL unless deliberately set but perhaps that is not the case on all mysql/mariadb versions |
|
@eileenmcnaughton I think the impact of this issue is fairly serious. Scheduled Reminders will fail to execute, which is a silent fail. And CiviCRM administrators are only made aware of the issue when business processes start failing. It's not difficult to identify if a CiviCRM site is affected by querying the civicrm_action_schedule table and effective_start_date, effective_end_date columns for values '0000-00-00 00:00:00'. If there's rows, then those Scheduled Reminders will simply not work. I did try to reproduce creating this invalid data thru the UI, but couldn't repeat which was very annoying. My next guess was that it may have been created during the CiviCRM database upgrade - I didn't test that explicitly. TL:DR Silent failures, very problematic. |
|
@agileware-justin ok - are you able to switch this to being against the rc - 5.41 & we can merge & then port to 5.40 |
…fective End Date are incorrectly evaluated if these fields contain a value '0000-00-00 00:00:00'
1b8166b to
71a9c04
Compare
| $startDateClauses[] = "'{$actionSchedule->effective_start_date}' <= {$date}"; | ||
| } | ||
| if (!empty($actionSchedule->effective_end_date)) { | ||
| if (!empty($actionSchedule->effective_end_date) && $actionSchedule->effective_end_date !== '0000-00-00 00:00:00') { | ||
| $startDateClauses[] = "'{$actionSchedule->effective_end_date}' > {$date}"; |
There was a problem hiding this comment.
For the record, I've tried various paths to reproduce the situation where the value is 0000-00-00 00:00:00 and had no success. e.g.
- Upgrade 5.39.latest => 5.40.latest on MySQL 5.7.23
- Upgrade 5.33.latest => 5.40.latest on MySQL 5.7.23
- Upgrade 5.33.latest => 5.40.0 and then use the admin UI, alternately setting/saving/clearing the value. (There had been some bug in saving this field circa
5.40.0-5.40.3; so an early 5.40.x might've had the problem)
Without that, it's hard to affirmatively describe the proper resolution. But, as a sort of work-around, this seems safe enough.
There was a problem hiding this comment.
@totten thanks for that - I think the issue depends on mysql config - (NO_ZERO_IN_DATE,NO_ZERO_DATE or something like that)
There was a problem hiding this comment.
Who knows how, but have seen two sites with this issue so far and that's enough to warrant a fix IMHO. Thanks for checking.
CiviCRM Scheduled Reminders, Effective Start Date and Effective End Date are incorrectly evaluated if these fields contain a value '0000-00-00 00:00:00'. See Gitlab, https://lab.civicrm.org/dev/core/-/issues/2787
Overview
See Gitlab, https://lab.civicrm.org/dev/core/-/issues/2787
Before
Scheduled Reminder is NOT sent when either the Effective Start Date or Effective End Date have a value of '0000-00-00 00:00:00'.
After
Scheduled Reminder IS sent when either the Effective Start Date or Effective End Date have a value of '0000-00-00 00:00:00'.
Technical Details
Comments
This problem relates to this PR #19973
Agileware Ref: CIVICRM-1820