Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change PDF file name from "civicrmContributionReceipt.pdf" to use the standard "receipt.pdf" file name #21221

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

agileware-justin
Copy link
Contributor

Change PDF file name from "civicrmContributionReceipt.pdf" to use the standard "receipt.pdf" file name

Overview

Change PDF file name from "civicrmContributionReceipt.pdf" to use the standard "receipt.pdf" file name

Before

This is the only place that CiviCRM creates a file called "civicrmContributionReceipt.pdf" for a receipt.

After

Uses the standard "receipt.pdf" file name.

Technical Details

Continues work of #21220 and #21006

Comments

Agileware Ref: CIVICRM-1813

…f" to use the standard "receipt.pdf" file name
@civibot
Copy link

civibot bot commented Aug 23, 2021

(Standard links)

@civibot civibot bot added the master label Aug 23, 2021
@eileenmcnaughton eileenmcnaughton added the merge ready PR will be merged after a few days if there are no objections label Aug 25, 2021
@eileenmcnaughton
Copy link
Contributor

Yeah that makes sense to me @mattwire @seamuslee001 @demeritcowboy - any hesitation?

@demeritcowboy
Copy link
Contributor

Now that it's a real word, might consider ts'ing it but then need to think about invalid filenames so can think about later.

@demeritcowboy demeritcowboy merged commit 18424b1 into civicrm:master Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master merge ready PR will be merged after a few days if there are no objections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants