[REF] Cleanup BAO::del() functions with unnecessary FK checks (dev/core#2757) #21199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were using PHP to enforce key constraints better taken care of by MySQL.
|
(Standard links)
|
colemanw
commented
Aug 20, 2021
| @@ -957,6 +957,7 @@ public static function deleteRecord(array $record) { | |||
| if (empty($record['id'])) { | |||
| throw new CRM_Core_Exception("Cannot delete {$entityName} with no id."); | |||
| } | |||
| CRM_Utils_Type::validate($record['id'], 'Positive'); | |||
There was a problem hiding this comment.
This is the only thing I moved into the generic function from Tag::del() which seems like a reasonable sanity check.
| * @throws \CRM_Core_Exception | ||
| */ | ||
| public static function del($productID) { | ||
| //check dependencies |
There was a problem hiding this comment.
OK - so to confirm this one it's a case of doing an r-run to verify that I can't delete a product if a premiums product entry exists.
I believe that the premiums product is the fact that someone 'bought' that product but I have to confirm that !
There was a problem hiding this comment.
Yes, something like that :)
|
I tested both of these (r-run using apiv4) & confirmed the product wouldn't delete when assigned & the entity tags were deleted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Broken off from a larger cleanup PR #21200. These are the non-no-brainers which a reviewer should double-check for accuracy.
Before
These were using PHP to enforce key constraints better taken care of by MySQL.
After
Just leave it to MySQL to do its thing with foreign key checks and deprecate the functions in favor of generics.
Comments
A reviewer should note that
civicrm_entity_tagusesON DELETE CASCADE, making the php function here redundant. AndPremiumsProductdoes NOT cascade, again making this php function redundant.