dev/rc#14 handle api calls post schema change

[eileenmcnaughton]

Overview

dev/rc#14 handle api calls post schema change

Before

Calling v3 api MembershipType.create with 'auto_renew' => TRUE works on 5.40 but fails on 5.41

After

Also works on 5.41 - unsure about v4 api, I suspect it doesn't

Technical Details

The schema oddly had auto_renew as a boolean although as a TINYINT it could actually record all 3 valid values (0, 1 or 2). A fix to the schema in 5.41 caused this to start failing - at least in tests

This adds hack-handling for the v3 api but I'm undecided about v4 api. I haven't tested, suspect there would also be an issue. However the relative rarity of MembershipType.create being called outside of tests is mitigating

Comments

@colemanw @KarinG

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

I agree about leaving off a v4 fix.

[KarinG]

Thank you @eileenmcnaughton - It's getting later here - I did want to comment that I agree MembershipType.create is rarely called outside of tests. It's just for the tests set up.

[eileenmcnaughton]

Thank you @eileenmcnaughton - It's getting later here - I did want to comment that I agree MembershipType.create is rarely called outside of tests. It's just for the tests set up.

updated above ^^